Skip to content

Make install scripts more consistent over different operating systems #9071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 8, 2019
Merged

Make install scripts more consistent over different operating systems #9071

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
693f420
Fix incorrect flags and make documentation consistent
Geweldig Mar 6, 2019
5325504
Fix exit codes, make checks consistent
Geweldig Mar 6, 2019
d1d14be
Remove commented code
Geweldig Mar 6, 2019
e1666d6
Fix grammar error
Geweldig Mar 6, 2019
b0bb14a
Make lowercase function consistent over all files
Geweldig Mar 6, 2019
26ce472
Remove legacy backticks
Geweldig Mar 6, 2019
742c9f2
Fix tr escaping
Geweldig Mar 6, 2019
ad28ee9
Resolve all Shellcheck warnings in install-powershell.sh
Geweldig Mar 6, 2019
12528e9
Fix all shellcheck errors for installpsh-amazonlinux.sh
Geweldig Mar 6, 2019
d5301c9
Resolve all ShellCheck errors
Geweldig Mar 6, 2019
0ed8ffa
Fix VSCode and Amazon Linux naming
Geweldig Mar 6, 2019
a220f15
Add more CI for install-ps.sh
TravisEz13 Mar 8, 2019
af58b9e
remove duplicate job
TravisEz13 Mar 8, 2019
487c330
fix typo
TravisEz13 Mar 8, 2019
9b9b36b
use container capable pool for containers
TravisEz13 Mar 8, 2019
6d50643
use images with powershell already in them
TravisEz13 Mar 8, 2019
d97396c
Add comment about broken distros
TravisEz13 Mar 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove commented code
  • Loading branch information
@Geweldig
Geweldig committed Mar 6, 2019
commit d1d14be9cd04436fa50a6ac0123ea2e5d1141e84
1 change: 0 additions & 1 deletion tools/installpsh-debian.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ trap '

#Verify The Installer Choice (for direct runs of this script)
lowercase(){
#echo "$1" | sed "y/ABCDEFGHIJKLMNOPQRSTUVWXYZ/abcdefghijklmnopqrstuvwxyz/"
echo "$1" | tr [A-Z] [a-z]
}

Expand Down
1 change: 0 additions & 1 deletion tools/installpsh-redhat.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ trap '

#Verify The Installer Choice (for direct runs of this script)
lowercase(){
#echo "$1" | sed "y/ABCDEFGHIJKLMNOPQRSTUVWXYZ/abcdefghijklmnopqrstuvwxyz/"
echo "$1" | tr [A-Z] [a-z]
}

Expand Down
1 change: 0 additions & 1 deletion tools/installpsh-suse.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ trap '

#Verify The Installer Choice (for direct runs of this script)
lowercase(){
#echo "$1" | sed "y/ABCDEFGHIJKLMNOPQRSTUVWXYZ/abcdefghijklmnopqrstuvwxyz/"
echo "$1" | tr [A-Z] [a-z]
}

Expand Down