-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding yml for Windows Release builds #8374
Conversation
Fixed CodeFactor issues. |
@adityapatwardhan pls look again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All comments are non-blocking
|
||
- powershell: | | ||
docker container prune --force | ||
docker container ls --all --format '{{ json .ID }}' | ConvertFrom-Json | %{docker container rm --force --volumes $_} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change %
to ForEach-Object
condition: and(succeeded(), ne(variables['SkipFxDependent'], 'true')) | ||
|
||
- powershell: | | ||
docker image ls --format '{{ json .}}'|ConvertFrom-Json|% { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change %
to ForEach-Object
|
||
- powershell: | | ||
docker container prune --force | ||
docker container ls --all --format '{{ json .ID }}' | ConvertFrom-Json | %{docker container rm --force --volumes $_} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change %
to ForEach-Object
continueOnError: true | ||
|
||
- powershell: | | ||
docker image ls --format '{{ json .}}'|ConvertFrom-Json|% { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change %
to ForEach-Object
PR Summary
As part of improving the build process, the UI build pipeline for Windows Builds was converted to a yml-based pipeline. (everything minus compliance tasks)
Verified on AzureDevOps mirror (pipeline
WIP-PowerShellCore-WindowsBuild-Yaml
): automated and manual runs.PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
to the beginning of the title and remove the prefix when the PR is ready.[feature]
if the change is significant or affects feature tests