Skip to content

Cleanup assemblyinfo - #8190

Merged
Travis Plunk (TravisEz13) merged 5 commits into
PowerShell:masterfrom
iSazonov:cleanup-assemblyinfo
Nov 16, 2018
Merged

Cleanup assemblyinfo#8190
Travis Plunk (TravisEz13) merged 5 commits into
PowerShell:masterfrom
iSazonov:cleanup-assemblyinfo

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented Nov 6, 2018 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

Remove old code from AssemblyInfo.cs

Additional considerations

We could use IgnoreAccessChecksToAttribute instead of InternalsVisibleToAttribute.

PR Checklist

@iSazonov

Ilya (iSazonov) commented Nov 6, 2018

Copy link
Copy Markdown
Collaborator Author

Seems Appveyor CI temporary failed.

@anmenaga

Andrew (anmenaga) commented Nov 6, 2018

Copy link
Copy Markdown

Restarted AppVeyor build.

anmenaga
Andrew (anmenaga) reviewed Nov 8, 2018
View reviewed changes
Comment thread src/Microsoft.Management.Infrastructure.CimCmdlets/AssemblyInfo.cs
using System.Reflection;
using System.Runtime.CompilerServices;

[assembly:InternalsVisibleTo("Microsoft.Windows.DSC.CoreConfProviders,PublicKey=0024000004800000940000000602000000240000525341310004000001000100b5fc90e7027f67871e773a8fde8938c81dd402ba65b9201d60593e96c492651e889cc13f1415ebb53fac1131ae0bd333c5ee6021672d9718ea31a8aebd0da0072f25d87dba6fc90ffd598ed4da35e44c398c454307e8e33b8426143daec9f596836f97c8f74750e5975c64e2189f45def46b2a2b1247adc3652bf5c308055da9")]

@anmenaga Andrew (anmenaga) Nov 8, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do you know that this is not used?

@iSazonov Ilya (iSazonov) Nov 8, 2018

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. It is for MSFT review.
I believe that internal and private visibility is permissible only in the repo. All other should use only public APIs or IgnoreAccessChecksToAttribute if needed.

@TravisEz13 Travis Plunk (TravisEz13) Nov 9, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll email DSC and ask.

@TravisEz13 Travis Plunk (TravisEz13) Nov 9, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the DSC team still needs this.

TravisEz13
Travis Plunk (TravisEz13) requested changes Nov 9, 2018
View reviewed changes

@TravisEz13 Travis Plunk (TravisEz13) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add DSC intervals visible to back

@iSazonov

Ilya (iSazonov) commented Nov 10, 2018

Copy link
Copy Markdown
Collaborator Author

Travis Plunk (@TravisEz13) Will do.
Could you please share why they need the visibility?
If they use it only for tests with precompiled dlls from the repo and use Roslyn they could migrate to using IgnoreAccessChecksToAttribute. Of cause if they still use old test system we have to keep the visibility for them.

@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Nov 12, 2018

Copy link
Copy Markdown
Member

Ilya (@iSazonov) Please push a commit with [Feature] tag to execute all tests.

@iSazonov

Ilya (iSazonov) commented Nov 13, 2018

Copy link
Copy Markdown
Collaborator Author

Travis Plunk (@TravisEz13) Please update your review.

@TravisEz13

Travis Plunk (TravisEz13) commented Nov 14, 2018

Copy link
Copy Markdown
Member

They do use the visibility for testing, but some of it is legacy.

TravisEz13
Travis Plunk (TravisEz13) reviewed Nov 14, 2018
View reviewed changes
Comment thread src/System.Management.Automation/AssemblyInfo.cs
[assembly: InternalsVisibleTo(@"Microsoft.PowerShell.GPowerShell" + @",PublicKey=0024000004800000940000000602000000240000525341310004000001000100b5fc90e7027f67871e773a8fde8938c81dd402ba65b9201d60593e96c492651e889cc13f1415ebb53fac1131ae0bd333c5ee6021672d9718ea31a8aebd0da0072f25d87dba6fc90ffd598ed4da35e44c398c454307e8e33b8426143daec9f596836f97c8f74750e5975c64e2189f45def46b2a2b1247adc3652bf5c308055da9")]
[assembly: InternalsVisibleTo(@"Microsoft.PowerShell.ISECommon" + @",PublicKey=0024000004800000940000000602000000240000525341310004000001000100b5fc90e7027f67871e773a8fde8938c81dd402ba65b9201d60593e96c492651e889cc13f1415ebb53fac1131ae0bd333c5ee6021672d9718ea31a8aebd0da0072f25d87dba6fc90ffd598ed4da35e44c398c454307e8e33b8426143daec9f596836f97c8f74750e5975c64e2189f45def46b2a2b1247adc3652bf5c308055da9")]
[assembly: InternalsVisibleTo(@"Microsoft.PowerShell.Editor" + @",PublicKey=0024000004800000940000000602000000240000525341310004000001000100b5fc90e7027f67871e773a8fde8938c81dd402ba65b9201d60593e96c492651e889cc13f1415ebb53fac1131ae0bd333c5ee6021672d9718ea31a8aebd0da0072f25d87dba6fc90ffd598ed4da35e44c398c454307e8e33b8426143daec9f596836f97c8f74750e5975c64e2189f45def46b2a2b1247adc3652bf5c308055da9")]
[assembly: InternalsVisibleTo(@"powershell_ise" + @",PublicKey=0024000004800000940000000602000000240000525341310004000001000100b5fc90e7027f67871e773a8fde8938c81dd402ba65b9201d60593e96c492651e889cc13f1415ebb53fac1131ae0bd333c5ee6021672d9718ea31a8aebd0da0072f25d87dba6fc90ffd598ed4da35e44c398c454307e8e33b8426143daec9f596836f97c8f74750e5975c64e2189f45def46b2a2b1247adc3652bf5c308055da9")]

@TravisEz13 Travis Plunk (TravisEz13) Nov 14, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why this was here?

@iSazonov Ilya (iSazonov) Nov 14, 2018

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They all relate to ISE. I think we can safely remove this.

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Nov 14, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were added when we had a full CLR build as well.

@iSazonov

Ilya (iSazonov) commented Nov 15, 2018

Copy link
Copy Markdown
Collaborator Author

Travis Plunk (@TravisEz13) Please update your review.

@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 16, 2018
@TravisEz13
Travis Plunk (TravisEz13) merged commit 2c3e935 into PowerShell:master Nov 16, 2018
@iSazonov
Ilya (iSazonov) deleted the cleanup-assemblyinfo branch November 16, 2018 18:25
Ilya (iSazonov) added a commit to iSazonov/PowerShell that referenced this pull request Nov 29, 2018
@iSazonov
Cleanup assemblyinfo (PowerShell#8190)
8bfe76d 
Remove old code from AssemblyInfo.cs
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
@iSazonov @TravisEz13
Cleanup assemblyinfo (PowerShell#8190)
3a6524c 
Remove old code from AssemblyInfo.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT
+1 more reviewer
@anmenaga Andrew (anmenaga) anmenaga left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iSazonov @anmenaga @adityapatwardhan @TravisEz13