Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup assemblyinfo #8190

Merged
merged 5 commits into from
Nov 16, 2018
Merged

Cleanup assemblyinfo #8190

merged 5 commits into from
Nov 16, 2018

Conversation

iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Nov 6, 2018 •
edited
Loading

PR Summary

Remove old code from AssemblyInfo.cs

Additional considerations

We could use IgnoreAccessChecksToAttribute instead of InternalsVisibleToAttribute.

PR Checklist

@iSazonov iSazonov requested a review from anmenaga as a code owner November 6, 2018 04:51
@iSazonov iSazonov force-pushed the cleanup-assemblyinfo branch from ff68ef6 to 1172f95 Compare November 6, 2018 12:07
@iSazonov
Copy link
Collaborator Author

iSazonov commented Nov 6, 2018

Seems Appveyor CI temporary failed.

@anmenaga
Copy link
Contributor

anmenaga commented Nov 6, 2018

Restarted AppVeyor build.

anmenaga
anmenaga reviewed Nov 8, 2018
View reviewed changes
src/Microsoft.Management.Infrastructure.CimCmdlets/AssemblyInfo.cs Outdated
using System.Reflection;
using System.Runtime.CompilerServices;

[assembly:InternalsVisibleTo("Microsoft.Windows.DSC.CoreConfProviders,PublicKey=0024000004800000940000000602000000240000525341310004000001000100b5fc90e7027f67871e773a8fde8938c81dd402ba65b9201d60593e96c492651e889cc13f1415ebb53fac1131ae0bd333c5ee6021672d9718ea31a8aebd0da0072f25d87dba6fc90ffd598ed4da35e44c398c454307e8e33b8426143daec9f596836f97c8f74750e5975c64e2189f45def46b2a2b1247adc3652bf5c308055da9")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do you know that this is not used?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. It is for MSFT review.
I believe that internal and private visibility is permissible only in the repo. All other should use only public APIs or IgnoreAccessChecksToAttribute if needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll email DSC and ask.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the DSC team still needs this.

TravisEz13
TravisEz13 requested changes Nov 9, 2018
View reviewed changes
Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add DSC intervals visible to back

@iSazonov
Copy link
Collaborator Author

@TravisEz13 Will do.
Could you please share why they need the visibility?
If they use it only for tests with precompiled dlls from the repo and use Roslyn they could migrate to using IgnoreAccessChecksToAttribute. Of cause if they still use old test system we have to keep the visibility for them.

@adityapatwardhan
Copy link
Member

@iSazonov Please push a commit with [Feature] tag to execute all tests.

@iSazonov
Copy link
Collaborator Author

@TravisEz13 Please update your review.

@TravisEz13
Copy link
Member

They do use the visibility for testing, but some of it is legacy.

TravisEz13
TravisEz13 reviewed Nov 14, 2018
View reviewed changes
src/System.Management.Automation/AssemblyInfo.cs
[assembly: InternalsVisibleTo(@"Microsoft.PowerShell.GPowerShell" + @",PublicKey=0024000004800000940000000602000000240000525341310004000001000100b5fc90e7027f67871e773a8fde8938c81dd402ba65b9201d60593e96c492651e889cc13f1415ebb53fac1131ae0bd333c5ee6021672d9718ea31a8aebd0da0072f25d87dba6fc90ffd598ed4da35e44c398c454307e8e33b8426143daec9f596836f97c8f74750e5975c64e2189f45def46b2a2b1247adc3652bf5c308055da9")]
[assembly: InternalsVisibleTo(@"Microsoft.PowerShell.ISECommon" + @",PublicKey=0024000004800000940000000602000000240000525341310004000001000100b5fc90e7027f67871e773a8fde8938c81dd402ba65b9201d60593e96c492651e889cc13f1415ebb53fac1131ae0bd333c5ee6021672d9718ea31a8aebd0da0072f25d87dba6fc90ffd598ed4da35e44c398c454307e8e33b8426143daec9f596836f97c8f74750e5975c64e2189f45def46b2a2b1247adc3652bf5c308055da9")]
[assembly: InternalsVisibleTo(@"Microsoft.PowerShell.Editor" + @",PublicKey=0024000004800000940000000602000000240000525341310004000001000100b5fc90e7027f67871e773a8fde8938c81dd402ba65b9201d60593e96c492651e889cc13f1415ebb53fac1131ae0bd333c5ee6021672d9718ea31a8aebd0da0072f25d87dba6fc90ffd598ed4da35e44c398c454307e8e33b8426143daec9f596836f97c8f74750e5975c64e2189f45def46b2a2b1247adc3652bf5c308055da9")]
[assembly: InternalsVisibleTo(@"powershell_ise" + @",PublicKey=0024000004800000940000000602000000240000525341310004000001000100b5fc90e7027f67871e773a8fde8938c81dd402ba65b9201d60593e96c492651e889cc13f1415ebb53fac1131ae0bd333c5ee6021672d9718ea31a8aebd0da0072f25d87dba6fc90ffd598ed4da35e44c398c454307e8e33b8426143daec9f596836f97c8f74750e5975c64e2189f45def46b2a2b1247adc3652bf5c308055da9")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why this was here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They all relate to ISE. I think we can safely remove this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were added when we had a full CLR build as well.

@iSazonov
Copy link
Collaborator Author

@TravisEz13 Please update your review.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 16, 2018
@TravisEz13 TravisEz13 merged commit 2c3e935 into PowerShell:master Nov 16, 2018
@iSazonov iSazonov deleted the cleanup-assemblyinfo branch November 16, 2018 18:25
iSazonov added a commit to iSazonov/PowerShell that referenced this pull request Nov 29, 2018
@iSazonov
Cleanup assemblyinfo (PowerShell#8190)
8bfe76d 
Remove old code from AssemblyInfo.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@anmenaga anmenaga anmenaga left review comments

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

Assignees

@TravisEz13 TravisEz13

Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iSazonov @anmenaga @adityapatwardhan @TravisEz13