Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cURL to the Bash users list in README.md #7948

Merged
merged 2 commits into from
Oct 9, 2018

Conversation

vmsilvamolina
Copy link
Contributor

@vmsilvamolina vmsilvamolina commented Oct 5, 2018

PR Summary

add the cURL example on the Bash users list

PR Checklist

@@ -100,7 +100,7 @@ Note that all bash commands should continue working on PowerShell session.
| rm -r <folderName> |Remove-Item <folderName> -Recurse |Delete a folder
| find -name build* |Get-ChildItem build* -Recurse |Find a file or folder starting with 'build'
| grep -Rin "sometext" --include="*.cs" |Get-ChildItem -Recurse -Filter *.cs <br> \| Select-String -Pattern "sometext" | Recursively case-insensitive search for text in files

| curl dominio.com | Invoke-WebRequest dominio.com | Transfer data from or to a web from differentes protocols
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Transfer data from web?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Invoke-RestMethod is more similar to curl than Invoke-WebRequest. Also, the example does work with curl and it's better to use a more generic URL:

curl https://github.com
Invoke-RestMethod https://github.com

For the description, maybe: Transfer data to or from the web

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll make the changes.

@@ -100,7 +100,7 @@ Note that all bash commands should continue working on PowerShell session.
| rm -r &lt;folderName> |Remove-Item &lt;folderName> -Recurse |Delete a folder
| find -name build* |Get-ChildItem build* -Recurse |Find a file or folder starting with 'build'
| grep -Rin "sometext" --include="*.cs" |Get-ChildItem -Recurse -Filter *.cs <br> \| Select-String -Pattern "sometext" | Recursively case-insensitive search for text in files

| curl dominio.com | Invoke-WebRequest dominio.com | Transfer data from or to a web from differentes protocols
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Invoke-RestMethod is more similar to curl than Invoke-WebRequest. Also, the example does work with curl and it's better to use a more generic URL:

curl https://github.com
Invoke-RestMethod https://github.com

For the description, maybe: Transfer data to or from the web

Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iSazonov iSazonov merged commit e29b5ee into PowerShell:master Oct 9, 2018
@iSazonov iSazonov changed the title add cURL to the Bash users list Add cURL to the Bash users list in README.md Oct 9, 2018
@iSazonov
Copy link
Collaborator

iSazonov commented Oct 9, 2018

@vmsilvamolina Thanks for your contribution!

adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants