Update docker files to use MCR #7656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapatwardhan
requested review from
anmenaga,
dantraMSFT and
daxian-dbw
as code owners
anmenaga
approved these changes
Aug 29, 2018
| @@ -1,6 +1,6 @@ | |||
| # escape=` | |||
| #0.3.6 (no powershell 6) | |||
| FROM microsoft/powershell:windowsservercore | |||
| FROM mcr.microsoft.com/powershell:windowsservercore | |||
There was a problem hiding this comment.
I noticed servercore dockerfile wasn't updated in the last PR (and it is using strange FROM location). Just FYI.
There was a problem hiding this comment.
That is just a sample in PSRelease repo.
TravisEz13
approved these changes
Aug 29, 2018
|
Restarted AppVeyor due to intermittent issue. |
|
@TravisEz13 Ready for merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Update to use mcr.microsoft.com as the docker repository.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests