Remove web cmdlet tests using proxy env variables #6808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markekraus
changed the title
markekraus
reviewed
May 3, 2018
| @@ -505,8 +505,8 @@ Describe "Invoke-WebRequest tests" -Tags "Feature" { | |||
| } | |||
|
|
|||
| $testCase = @( | |||
| @{ proxy_address = (Get-WebListenerUrl).Authority; name = 'http_proxy'; protocol = 'http' } | |||
| @{ proxy_address = (Get-WebListenerUrl -https).Authority; name = 'https_proxy'; protocol = 'https' } | |||
| @{ proxy_address = (Get-WebListenerUrl).Authority; name = 'http proxy'; protocol = 'http' } | |||
There was a problem hiding this comment.
If we are going to use soft names, we should use HTTP proxy and HTTPS proxy.
markekraus
approved these changes
May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #6804
Current .Net Core 2.1 socket based http client don't use
curlso we can safely remove the tests.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests