Skip to content

Update test-isfile to correct response for "/" #6754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2018
Merged

Update test-isfile to correct response for "/" #6754

merged 1 commit into from
May 3, 2018

Conversation

Patochun
Copy link
Contributor

I Think the good answer for "/" is a directory, not a file.

PR Summary

I recommand to change EXPECT_TRUE by EXPECT_FALSE for the case test "/".

PR Checklist

I Think the good answer for "/" is a directory, not a file.
So I recommand to change EXPECT_TRUE by EXPECT_FALSE for this case.
@iSazonov
Copy link
Collaborator

iSazonov commented May 2, 2018

@daxian-dbw @TravisEz13 Do you understand the PR?

@TravisEz13
Copy link
Member

@dantraMSFT Can you review?

@TravisEz13 TravisEz13 requested a review from dantraMSFT May 2, 2018 17:11
@Patochun
Copy link
Contributor Author

Patochun commented May 3, 2018

The change does not concern the error provided by Travis

@iSazonov
Copy link
Collaborator

iSazonov commented May 3, 2018

I restarted CI Travis Linux - Update-Help test temporary failed.

@TravisEz13 TravisEz13 merged commit 145cb77 into PowerShell:master May 3, 2018
@Patochun Patochun deleted the patch-1 branch May 4, 2018 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants