Skip to content

6.1.0. - Make explorer context menus platform specific to allow them to work when both x86 and x64 are installed #5824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bergmeister
Copy link
Contributor

PR Summary

Make explorer context menu registry entries platform specific to allow them to work also when both x86 and x64 are installed. The main menu has a " (x86)" appended to the main menu as well.
This issue was found a few days after the context menu was merged into master in an unrelated issue by @iSazonov
Some renaming was applied to existing variables to distinguish better between main menu and sub menu

image

PR Checklist

Note: Please mark anything not applicable to this PR NA.

…w side by side of x86 and x64. The main menu has a " (x86)" appended to the main menu.

Some renaming of existing variables to distinguish between main menu and sub menu
@iSazonov iSazonov requested a review from SteveL-MSFT January 9, 2018 03:33
@iSazonov iSazonov self-assigned this Jan 9, 2018
Copy link
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I don't check for x86.

Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iSazonov iSazonov merged commit 378e8d5 into PowerShell:master Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants