-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Cleanup Json cmdlets #5001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup Json cmdlets #5001
Conversation
|
||
return result; | ||
} | ||
#endif | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a newline since you're already updating this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Is it safe to assume that ImportJsonDotNetModule hasn't been needed for a while?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I asked in Gitter and only @vors commented:
Also I guess it could have been because of the problems with loading dlls in the PowerShell Core early port phases. I tried to list loaded assemblies and don't see Newton.Json 7.0 - only 10 version was loaded. @vors @daxian-dbw Could you please comment too? Is it safe? |
Yes, it's safe to remove it. @iSazonov Can you please change the last commit message to add |
There is one known failure. It failed due to a race condition between the test and the test service, not related to this PR. I will merge this PR.
|
Related #4357.
Cleanup Json cmdlets from FullCLR code.
Remove ImportJsonDotNetModule.
Update Newton.Json version 10.0.2 -> 10.0.3