-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Make a minor update to the FileInfo
table formatting on Unix to make it more concise
#18183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one minor comment.
PR Summary
Make a minor update to the
FileInfo
table formatting on Unix to make it a little more concise.The existing formatting has too much blank space in the table, which makes it a little hard to quick scan the file name column, which is at the right most.
A few changes to the view:
User
column, so thatUser
andGroup
are closely together.User
andGroup
to be 10 instead of 16. The old limit to username (like in Ubuntu 11.04) was 8 characters, and now the limit is 32 characters. I did a search on common Linux usernames, and most of the names I found falls under 10 characters. So, change the width to be 10 instead of 16 to reduce blank spaces of the table view.LastWriteTime
uses a fixed format for this view, so we can use the exact width, which is 16.Size
column or (length), using width 12 will allow us to show a file size of931 gb
without truncating, which should be sufficient in most cases.PR Context
Before the change:
After the change:
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.