Fix the test that fails in Travis CI build #1792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxian-dbw
added
Review - Needed
Area-Maintainers-Build
4 tasks
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
use of a module from two runspacesset/tmp/<guid-number>in$env:PSMODULEPATH. However, the file/tmp/powershellsomehow exists in the Travis CI build machine. So when the test create a powershell object by[powershell]::create(), the module path calculation logic incorrectly believed that/tmp/<guid-number>is a PSHome module path derived from parent process and thus removed it.The detection of a derived PSHome module path could be smarter, it's tracked in #1744
This PR will resolve the failure from the test side, so that our build can be fixed.