Skip to content

remove a number of assertions which cause debug build test runs to fail #15963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 22, 2021

Conversation

JamesWTruher
Copy link
Collaborator

PR Summary

This removes 4 assertions which cause a debug build test run to fail.

PR Context

in order to run code coverage, we need to have a debug build, but a number of assertions cause the test run to fail. This PR removes those assertions.

PR Checklist

@daxian-dbw daxian-dbw assigned daxian-dbw and unassigned anmenaga Aug 20, 2021
@daxian-dbw daxian-dbw merged commit c39d672 into PowerShell:master Aug 22, 2021
@anmenaga anmenaga added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 13, 2021
@ghost
Copy link

ghost commented Dec 16, 2021

🎉v7.3.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

@JamesWTruher JamesWTruher deleted the AssertRemove001 branch September 23, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants