Skip to content

Mark private members as static part 2 #14225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2020
Merged

Mark private members as static part 2 #14225

merged 1 commit into from
Nov 24, 2020

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Nov 23, 2020 •
edited
Loading

src/Microsoft.PowerShell.Commands.Diagnostics/

Contributes to #13897.

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822

@ghost ghost assigned anmenaga Nov 23, 2020
@xtqqczze xtqqczze changed the title Fix CA1822: Mark members as static part 2 Mark private members as static part 2 Nov 23, 2020
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 23, 2020
@iSazonov iSazonov merged commit 4ab1b90 into PowerShell:master Nov 24, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Nov 24, 2020
@iSazonov iSazonov assigned iSazonov and unassigned anmenaga Nov 24, 2020
@xtqqczze xtqqczze deleted the CA1822-p2 branch November 24, 2020 09:02
@ghost
Copy link

ghost commented Dec 15, 2020

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iSazonov iSazonov iSazonov approved these changes

Assignees

@iSazonov iSazonov

Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
None yet
Milestone
7.2.0-preview.2
Development

Successfully merging this pull request may close these issues.
3 participants
@xtqqczze @iSazonov @anmenaga