Skip to content

Reformat StringUtil #13509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2020
Merged

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Aug 24, 2020

PR Summary

  • Add using System.Globalization
  • Class declaration keywords all on same line.
  • Use correct naming convention for static readonly member (s_indentCache instead of IndentCache)
  • Remove double blank line at EOF.

PR Context

Follow-up: #13408

PR Checklist

@ghost ghost assigned daxian-dbw Aug 24, 2020
Copy link
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xtqqczze Please revert LocalAccounts/StringUtil.cs - it is frozen code and it is excluded from compilation.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 27, 2020
@xtqqczze xtqqczze force-pushed the refactor-stringutil branch from 99087aa to cee0bc6 Compare August 28, 2020 23:42
@xtqqczze xtqqczze changed the title WIP: Refactor StringUtil Reformat StringUtil Aug 28, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 28, 2020
@xtqqczze xtqqczze marked this pull request as ready for review August 28, 2020 23:46
@xtqqczze
Copy link
Contributor Author

@iSazonov PR is now just a quick reformat.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Aug 29, 2020
@iSazonov iSazonov merged commit 83079f6 into PowerShell:master Aug 29, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.7 milestone Aug 29, 2020
@xtqqczze xtqqczze deleted the refactor-stringutil branch August 29, 2020 17:22
@ghost
Copy link

ghost commented Sep 8, 2020

🎉v7.1.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants