Skip to content

Fix RCS1033: Remove redundant boolean literal part 1 #13454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2020

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Aug 15, 2020

PR Summary

Changes should be reviewed with commits combined.

Autofix RCS1033: Remove redundant boolean literal

Due to size, changes to System.Management.Automation were excluded and will be presented in a seperate PR.

PR Context

#13334

PR Checklist

@xtqqczze
Copy link
Contributor Author

@iSazonov Can you review, again :(

@rjmholt rjmholt added Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers Review - Needed The PR is being reviewed labels Aug 15, 2020
@xtqqczze
Copy link
Contributor Author

@TravisEz13 can you please review?

@rjmholt
Copy link
Collaborator

rjmholt commented Sep 1, 2020

@xtqqczze what's the full size of all the changes for this? We need to understand the risk for things like commit conflicts and cherry picks. For this and some other style changes, it may be worth opening tracking issues so that work can be broken down into manageable pieces.

@ghost ghost removed the Review - Needed The PR is being reviewed label Sep 1, 2020
@daxian-dbw
Copy link
Member

@PowerShell/powershell-maintainers reviewed this PR and agreed to accept it for 7.2-preivew. So we should delay merging it until after 7.1-RC1 release branch gets created.

The changes make sense and the chance of confliction is relatively low, but it requires line-by-line review to make sure there is no potential incorrect change, so it's better to delay merging it till 7.2 preview to avoid possible regression.

@daxian-dbw daxian-dbw removed the Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers label Sep 1, 2020
@iSazonov iSazonov marked this pull request as draft September 2, 2020 03:13
@iSazonov
Copy link
Collaborator

iSazonov commented Sep 2, 2020

Set to Draft till 7.2 Preview1.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 5, 2020
@ghost ghost added the Stale label Sep 20, 2020
@ghost
Copy link

ghost commented Sep 20, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@ghost ghost closed this Sep 30, 2020
@rjmholt rjmholt removed Stale Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Sep 30, 2020
@rjmholt rjmholt reopened this Sep 30, 2020
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 3, 2020
@ghost ghost added the Stale label Oct 18, 2020
@ghost
Copy link

ghost commented Oct 18, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@iSazonov iSazonov marked this pull request as ready for review October 19, 2020 04:19
@iSazonov
Copy link
Collaborator

@rjmholt @SteveL-MSFT I think we can merge.

@ghost ghost removed the Stale label Oct 19, 2020
@xtqqczze
Copy link
Contributor Author

CodeFactor issues are pre-existing.

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 22, 2020
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 22, 2020
@xtqqczze
Copy link
Contributor Author

@rjmholt Could you help merge, this is blocking #13833.

@xtqqczze xtqqczze changed the title Remove redundant boolean literal part 1 Fix RCS1033: Remove redundant boolean literal part 1 Oct 29, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 5, 2020
@ghost
Copy link

ghost commented Nov 5, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov
Copy link
Collaborator

iSazonov commented Nov 5, 2020

@xtqqczze Please resolve merge conflicts.

@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 5, 2020
@iSazonov iSazonov assigned iSazonov and unassigned rjmholt Nov 5, 2020
@iSazonov iSazonov merged commit 76be8f3 into PowerShell:master Nov 5, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.1 milestone Nov 5, 2020
@xtqqczze xtqqczze deleted the RCS1033 branch November 5, 2020 21:25
@ghost
Copy link

ghost commented Nov 17, 2020

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants