-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Fix RCS1033: Remove redundant boolean literal part 1 #13454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Autofix RCS1033: Remove redundant boolean literal
@iSazonov Can you review, again :( |
@TravisEz13 can you please review? |
@xtqqczze what's the full size of all the changes for this? We need to understand the risk for things like commit conflicts and cherry picks. For this and some other style changes, it may be worth opening tracking issues so that work can be broken down into manageable pieces. |
@PowerShell/powershell-maintainers reviewed this PR and agreed to accept it for 7.2-preivew. So we should delay merging it until after 7.1-RC1 release branch gets created.
|
Set to Draft till 7.2 Preview1. |
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment. |
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment. |
@rjmholt @SteveL-MSFT I think we can merge. |
CodeFactor issues are pre-existing. |
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
@xtqqczze Please resolve merge conflicts. |
🎉 Handy links: |
PR Summary
Changes should be reviewed with commits combined.
Autofix RCS1033: Remove redundant boolean literal
Due to size, changes to
System.Management.Automation
were excluded and will be presented in a seperate PR.PR Context
#13334
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.