Change Add-Type -OutputType to not support ConsoleApplication and WindowsApplication

[daxian-dbw]

PR Summary

Related issue: #13344
The output assembly type ConsoleApplication and WindowsApplication doesn't work with Add-Type today.
Per the conclusion of the powershell committee, this PR changes Add-Type -OutputType to throw terminating error when either ConsoleApplication or WindowsApplication is used.

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Experimental feature(s) needed
    • Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed: Change Add-Type -OutputType to not support ConsoleApplication and WindowsApplication MicrosoftDocs/PowerShell-Docs#6499
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
    • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
    • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
    • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
    • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[iSazonov]

I'd wait Ryslyn team answer. If they have not plans to fix this we can remove the code and add throw. Otherwise it is better to add ValidationSet attribute - less changes to revert.

[daxian-dbw]

Adding ValidationSet attribute will be very confusing -- it's a enum type parameter but some members don't work because of the ValidationSet. That makes the ValidateSet attribute more like a bug.
Also, the changes in this PR is very trivial, so it will also be a trivial work to revert the changes when someone gets to fix it (if it's fixable).

[iSazonov]

Adding ValidationSet attribute will be very confusing -- it's a enum type parameter but some members don't work because of the ValidationSet.

I mean we can use string values and add a comment with link to tracking issue.

[daxian-dbw]

The changes in this PR is trivial, and reverting it when it needs to is also trivial, so I don't think we need to do it differently.

[daxian-dbw]

@anmenaga I think this PR is ready to merge.

[iSazonov]

We could keep #13344 open for tracking.

[ghost]

🎉v7.1.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes