Change Read-Host -MaskInput to use existing SecureString path, but return as plain text

[SteveL-MSFT]

PR Summary

#10908 introduced a new -MaskInput switch to enable hiding the input while still returning a string. It did this by introducing a new method ReadLineMaskedAsString(), however, this was not necessary and would not be supported by remoting as it required hosts to implement it. It also did not support use of -MaskInput with -Prompt.

The change here is to revert most of the changes in that PR to instead use existing ReadLineAsSecureString() method which would already be implemented by different hosts and convert to a string if -MaskInput is used.

PR Context

Fix #13011

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Experimental feature(s) needed
    • Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • [Documentation needed] Document Read-Host new parameter called MaskInput MicrosoftDocs/PowerShell-Docs#5021
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
    • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
    • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
    • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
    • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[rjmholt]

The host change makes me think we should have more SDK tests, particularly a test host implementation, so we have a good litmus test for breaking changes in the API surface

[SteveL-MSFT]

@PoshChan please retry macos

[PoshChan]

@SteveL-MSFT, did not find matching build context: PowerShell-CI-macOS; allowed contexts: PowerShell-CI-SSH

[daxian-dbw]

LGTM except for one minor comment.

[daxian-dbw]

@SteveL-MSFT Can you please resolve the conflict? mac CI failing tests are marked as pending for now, so CI should pass after you rebase.

[daxian-dbw]

@PoshChan Please remind me in 1 hour

[PoshChan]

@daxian-dbw, this is the reminder you requested 1 hour ago

[ghost]

🎉v7.1.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes