Change packaging to produce LTS packages
#11772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create pwsh-lts symbolic link Build LTS packages in addition to stable Revert vstsbuild changes Make PowerShellPackage.ps1 build LTS packages
Avoid checking ReleaseTag when doing bootstrap Add LTS switch for pkg build Mac signing changes
adityapatwardhan
requested review from
anmenaga,
daxian-dbw and
TravisEz13
as code owners
ghost
assigned
TravisEz13
reviewed
Feb 4, 2020
TravisEz13
reviewed
Feb 4, 2020
tools/packaging/packaging.psm1
Outdated
| @@ -1416,7 +1449,7 @@ function New-MacOSLauncher | |||
| $plistcontent | Out-File -Force -Path $plist -Encoding utf8 | |||
|
|
|||
| # Create shell script. | |||
| $executablepath = if ($IsPreview) { "/usr/local/bin/pwsh-preview" } else { "/usr/local/bin/pwsh" } | |||
| $executablepath = if ($IsPreview) { "/usr/local/bin/pwsh-preview" } elseif ($LTS) { "/usr/local/bin/pwsh-lts"} else { "/usr/local/bin/pwsh" } | |||
There was a problem hiding this comment.
This is the 3rd place this code is duplicated
There was a problem hiding this comment.
refactored to a function
TravisEz13
approved these changes
Feb 4, 2020
|
@PoshChan Please remind me in 1 hour |
TravisEz13
added
the
CL-BuildPackaging
|
@TravisEz13, this is the reminder you requested 1 hour ago |
adityapatwardhan
added a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Feb 18, 2020
|
🎉 Handy links: |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Make changes to the packaging scripts to produce LTS packages in addition to regular packages when the minor version is even.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.