Skip to content

Remove the unused setting key ConsolePrompting and avoid unnecessary string creation when querying ExecutionPolicy setting #10985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 6, 2019

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Nov 4, 2019

PR Summary

Remove the unused setting key ConsolePrompting and avoid unnecessary string creation when querying ExecutionPolicy setting
The ConsolePrompting setting is not used anywhere because the functionality depended on it was not supporting and had been removed in #4995

The changes to GetExecutionPolicy, RemoveExecutionPolicy and SetExecutionPolicy avoid unnecessary string allocation for the default PowerShell shell Id.

PR Context

PR Checklist

@daxian-dbw daxian-dbw requested a review from iSazonov November 4, 2019 20:36
@daxian-dbw daxian-dbw added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 4, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.6 milestone Nov 6, 2019
@iSazonov iSazonov merged commit 6aa3188 into PowerShell:master Nov 6, 2019
@daxian-dbw daxian-dbw deleted the config branch November 6, 2019 07:24
@ghost
Copy link

ghost commented Nov 21, 2019

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants