Skip to content

Fix NRE in PSConfiguration.cs #10963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2019

Conversation

iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Nov 1, 2019

PR Summary

ReadValueFromFile<T> method returns null for the powershell.config.json file (discovered in VS Code Launch scenario):

{
  "ExperimentalFeatures": null,
  "Microsoft.PowerShell:ExecutionPolicy": "RemoteSigned"
}

PR Context

PR Checklist

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 1, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.6 milestone Nov 1, 2019
@iSazonov iSazonov requested a review from daxian-dbw November 1, 2019 05:54
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw added CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log and removed CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log labels Nov 1, 2019
@daxian-dbw daxian-dbw merged commit 417cbd7 into PowerShell:master Nov 1, 2019
@iSazonov iSazonov deleted the nre-in-psconfiguration branch November 1, 2019 17:40
@ghost
Copy link

ghost commented Nov 21, 2019

🎉v7.0.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants