-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Make ConvertTo-Json
treat [AutomationNull]::Value
and [NullString]::Value
as $null
#10957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PoshChan
reviewed
Oct 31, 2019
src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/JsonObject.cs
Show resolved
Hide resolved
PoshChan
reviewed
Oct 31, 2019
src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/JsonObject.cs
Show resolved
Hide resolved
anmenaga
reviewed
Oct 31, 2019
test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertTo-Json.Tests.ps1
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertTo-Json.Tests.ps1
Show resolved
Hide resolved
PoshChan
reviewed
Oct 31, 2019
src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/JsonObject.cs
Show resolved
Hide resolved
anmenaga
approved these changes
Nov 1, 2019
Rebased to resolve conflicts. |
PoshChan
reviewed
Nov 4, 2019
src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/JsonObject.cs
Show resolved
Hide resolved
PoshChan
reviewed
Nov 4, 2019
src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/JsonObject.cs
Show resolved
Hide resolved
@PoshChan Please retry static |
@PoshChan Please retry linux |
@daxian-dbw, successfully started retry of |
@daxian-dbw, successfully started retry of |
PoshChan
reviewed
Nov 5, 2019
src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/JsonObject.cs
Show resolved
Hide resolved
SteveL-MSFT
approved these changes
Nov 5, 2019
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaking-Change
breaking change that may affect users
CL-General
Indicates that a PR should be marked as a general cmdlet change in the Change Log
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #9231
Make
ConvertTo-Json
treat[AutomationNull]::Value
and[NullString]::Value
as$null
This is a breaking change given the fact that
[AutomationNull]::Value
and[NullString]::Value
are deserailized into an empty object{}
today and will benull
after this change.However, it's hard to believe anyone is depending on the current wrong behavior.
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.