Add back Get-HotFix cmdlet

[SteveL-MSFT]

PR Summary

Re-enable Get-HotFix cmdlet on Windows. Since the WmiHelper class relies on WMI cmdlets, rewrote the code a bit to not use it. Added tests that depend on Win32_QuickFixEngineering WMI class returning results. Removed a bunch of referenced namespaces in the original source file that aren't needed as well as an old comment.

PR Context

Fix #2296

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Experimental feature(s) needed
    • Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed: Add Get-HotFix documentation back for PS7 MicrosoftDocs/PowerShell-Docs#4908
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
    • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
    • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
    • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
    • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[adityapatwardhan]

Should this just re-written over MMI / CIM APIs, seems simple enough? It would be like:

[cimsession]::Create('localhost').QueryInstances("root/cimv2", 'WQL', 'select * from Win32_QuickFixEngineering')

or

[cimsession]::Create('localhost').QueryInstances("root/cimv2", 'WQL', 'select * from Win32_QuickFixEngineering where hotfixid="KB4514359"')

[SteveL-MSFT]

@adityapatwardhan doesn't seem to provide much benefit to rewrite. We could have rewrote it in PS6 timeframe as it would have made sense then.

[anmenaga]

Tiny Codacy issue in new code should be fixed.

Btw, is there info on when (approximately:year/PSVersion) Get-HotFix was removed?

[SteveL-MSFT]

@anmenaga Get-HofFix was removed from PSCore6.0 because the System.Management namespace wasn't available.

[bergmeister]

Minor nit: For a cleaner history, it would've been be nice if parentheses/commas were placed in such a way that the last line does not require any change for the next addition (i.e. have the closing parenthesis in this case on the next line).

[bergmeister]

Wow, was powershell v1 supported on win95 (I though PS came out only around the XP times)? Or is this still from Monad days?

[SteveL-MSFT]

Not sure if v1 actually supported 95, although I suspect not. This error seems like a developer trying to cover their bases for exceptions.

[bergmeister]

@SteveL-MSFT Out of interest: Is there a list of issues or tags for low hanging fruits of cmdlets that can now be brought back relatively easily with .Net Core 3?

[SteveL-MSFT]

@bergmeister probably this one at least for Utility module: #2123, there's a few open issues on specific cmdlets. I already have a PR open for Clipboard cmdlets.

[iSazonov]

Updated comment there #2123 (comment)

[iSazonov]

Also DefaultCommands.Tests.ps1 is good source.

[ghost]

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes