-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Add MacPorts
support to the build system
#10736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MacPorts is one of the "Missing package managers for OS X". The original build scripts only supported Homebrew and it is inadvised to have both installed on a same system. This change makes the build script use whatever package manager is currently installed, or direct the user to download one of them if neither is present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
There is a spelling error. Here is my function to test spelling. function Test-Spelling
{
param(
[string[]]
$Paths,
[switch]
$Fix
)
if(!(Get-Command mdspell -ErrorAction SilentlyContinue))
{
brew install yarn
sudo yarn global add 'markdown-spellcheck@0.11.0'
}
$fileList = @()
foreach($path in $Paths)
{
if($path -match '^\.[/\\]')
{
$fileList += ($path -replace '^\.[/\\]')
}
else {
$fileList += $path
}
}
$extraParams = @()
if(!$Fix.IsPresent)
{
$extraParams += '--report'
}
Write-Verbose "Testing spelling for $fileList" -Verbose
mdspell $fileList --ignore-numbers --ignore-acronyms @extraParams --en-us --no-suggestions
} |
The script only complains about the words "2.x" (referring to the required .net core version) and "MacPorts". Looks like false positives to me. |
Spelling errors must be fixed for the PR to be accepted. Please run the tool and add the words to the dictionary. There is a fix switch in my script which will prompt you to add it to the dictionary |
There was a random failure verifying a URL. I retried that task. |
@PoshChan Please remind me in 1 hour |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hold for compliance review
@Lucius-Q-User To explain what triggered the review, MacPorts license is not clearly declared on GitHub (image below). So, I'm waiting on a manual review of the use of this software in our project. They don't give me a specific ETA. MacPro LicenseMIT License |
@TravisEz13, this is the reminder you requested 1 hour ago |
@Lucius-Q-User I'm monitoring the compliance review and I'd expect an answer within a week at this point. Ping me if we don't get an answer by that time. |
MacPorts
support to the build system
🎉 Handy links: |
PR Summary
Add MacPorts support to the build system
PR Context
MacPorts is one of the "Missing package managers for OS X".
The original build scripts only supported Homebrew and it is inadvised to have
both installed on a same system.
This change makes the build script use whatever package manager is currently
installed, or direct the user to download one of them if neither is present.
The build documentation has been updated to reflect that another package
manager is now also supported.
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.