Replace Ambiguous language for tests from switch to parameter for accuracy

[romero126]

PR Summary

Replace Ambiguous language for pester tests.
Pester tests for Remove-Item used incorrect terminology using switch analogous with Parameter

PR Context

Modify incorrect terminology, to use parameter instead of switch.

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Experimental feature(s) needed
    • Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
    • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
    • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
    • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
    • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[sdwheeler]

The more proper term would be parameter rather than argument

[romero126]

Hey Sean, I thought the same thing at first. However after looking deeply at the terminology. I decided the term "argument" would be better. Because "parameter" is the "-value" or $variable that gets defined when the argument is passed into the command.

https://www.quora.com/What-is-the-difference-between-argument-and-parameters-in-C

Is there an official consensus that the PowerShell team uses over the conventional comp sci answer?

Quora

What is the difference between argument and parameters in C?

Answer (1 of 8): A parameter is a variable in a method definition.

When a method is called, the arguments are the data you pass into the method's parameters.

Parameter is variable in the declaration of function.

Argument is the actual value of this variable that gets passed to function.

[sdwheeler]

@romero126 In PowerShell and in this example -Path is the parameter being tested $testfilepath is the argument value being passed.

[SteveL-MSFT]

I agree with @sdwheeler here. Switch is definitely wrong. Reading the name of the test, it's referring to the Path parameter.

[romero126]

Thank you @sdwheeler and @SteveL-MSFT for the feedback. I would have replied sooner but I got a little busy.

[iSazonov]

@sdwheeler Please update your review.

[iSazonov]

@romero126 Thanks for your contribution!

[ghost]

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes