-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Reword access denied error message in Get-WinEvent #10639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reword access denied error message in Get-WinEvent #10639
Conversation
@joeyaiello @SteveL-MSFT Could you please look the new error message? |
src/Microsoft.PowerShell.Commands.Diagnostics/resources/GetEventResources.resx
Show resolved
Hide resolved
@@ -253,7 +253,7 @@ The defined template is following: | |||
<value>The following value is not in a valid DateTime format: {0}.</value> | |||
</data> | |||
<data name="LogInfoUnavailable" xml:space="preserve"> | |||
<value>Could not retrieve information about the {0} log. Error: {1}.</value> | |||
<value>{1} To access the '{0}' log start PowerShell by using the "Run as Administrator" command.</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Run as Administrator" is a Windows Shell specific thing, may be better to say: ...start PowerShell with elevated user rights
(I searched and we use this type of language already in existing resource strings)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
We need to review all resx file for "using the "Run as Administrator" command".
@SteveL-MSFT Please update your code review. |
src/Microsoft.PowerShell.Commands.Diagnostics/resources/GetEventResources.resx
Outdated
Show resolved
Hide resolved
…ntResources.resx Co-Authored-By: Steve Lee <slee@microsoft.com>
🎉 Handy links: |
PR Summary
Fix #10637
New reworded message:
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.