Adding New-Service to -SecurityDescriptorSDDL parameter like Set-Service

[kvprasoon]

PR Summary

This PR is to add -SecurityDescriptorSDDL parameter to New-Service cmdlet so that its in par with Set-Service in setting sddl for a service.

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Experimental feature(s) needed
    • Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed: Add documentation for new -SecurityDescriptorSddl parameter of New-Service MicrosoftDocs/PowerShell-Docs#4735
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
    • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
    • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
    • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
    • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[iSazonov]

Extra spaces in two lines above.

[kvprasoon]

Thanks, why didn't CodeFactor catch this ?

[iSazonov]

Sometimes it is not predictable :-)

[iSazonov]

Indentation must be 4 spaces.

[kvprasoon]

Thanks, why didn't CodeFactor catch this ?

[adityapatwardhan]

@PoshChan please retry static

[adityapatwardhan]

would this work?

service = new ServiceController(Name);

if (!string.IsNullOrEmpty(SecurityDescriptorSddl))
{
    SetServiceSecurityDescriptor(service, SecurityDescriptorSddl, hService);
}

[vexx32]

That's a parameter, right? Shouldn't we be using if (MyInvocation.BoundParameters.ContainsKey(nameof(SecurityDescriptorSddl))) { ... } for parameters?

[kvprasoon]

@adityapatwardhan @vexx32 yes, I've used the same way how its implemented for Set-Service. I referred

L1883 if (!string.IsNullOrEmpty(Status)) which is used for -Status parameter in Set-Service.

[adityapatwardhan]

@kvprasoon Please follow the template and file a doc issue for the new parameter. If it is filed, please paste the link here.

[kvprasoon]

doc changes MicrosoftDocs/PowerShell-Docs#4735

[iSazonov]

@kvprasoon Thanks for your contribution! Sorry for delay.

[ghost]

🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes