Skip to content

Support notification on pwsh startup when a new update is available #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 19, 2020
Merged

Support notification on pwsh startup when a new update is available #162

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
83daf22
Support notification on pwsh startup for new updates
daxian-dbw Mar 24, 2019
576752b
Fix typo -- Non-Goals
SteveL-MSFT Mar 25, 2019
61f065c
Fix typo -- per day
SteveL-MSFT Mar 25, 2019
33a6db4
Update to be more accurate on the implementation
daxian-dbw Mar 28, 2019
d1f96af
Address comments, update according to the implementation
daxian-dbw Oct 3, 2019
213298b
Update RFC with the new environment variable settings
daxian-dbw Oct 28, 2019
189782f
Update the RFC based on the implementation
daxian-dbw Nov 20, 2019
c5690d6
Minor update
daxian-dbw Nov 20, 2019
4227289
Mention the message is printed with foreground and background colors …
daxian-dbw Feb 4, 2020
cc0a2a9
Address comment
daxian-dbw Feb 5, 2020
5769b2f
Prepare RFC0052 (update notifications) for merging as Final
joeyaiello Feb 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo -- per day 
Co-Authored-By: daxian-dbw <dongbow@microsoft.com>
  • Loading branch information
@SteveL-MSFT @daxian-dbw
SteveL-MSFT and daxian-dbw authored Mar 25, 2019
commit 61f065c49e4395fae4a3cb28fc7bd8f20c7213e7
2 changes: 1 addition & 1 deletion 1-Draft/RFCNNNN-Notification-On-Version-Update.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ This means the check for update must not happen during `pwsh` startup.
The only acceptable extra overhead to the `pwsh` startup should just be the work related to printing the notification.

4. Check for updates should not blindly run for every interactive `pwsh` session.
For a particular version of `pwsh`, only one check at most can run to complete per a day
For a particular version of `pwsh`, only one check at most can run to complete per day
no matter how many interactive session of the `pwsh` are started/opened in that day.

5. After a new update is detected during a successful check,
Expand Down