Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Markdown in ScriptRuleDocumentation.md so it renders correctly on GitHub web site #898

Merged
merged 1 commit into from
Feb 20, 2018
Merged

Fix Markdown in ScriptRuleDocumentation.md so it renders correctly on GitHub web site #898

merged 1 commit into from
Feb 20, 2018

Conversation

MWL88
Copy link
Contributor

@MWL88 MWL88 commented Feb 19, 2018 •
edited by bergmeister
Loading

PR Summary

Fixes #897
Update ScriptRuleDocumentation.md so it renders correctly on the GitHub web site.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • [NA] Summarized changes
  • [NA] User facing documentation needed
  • Change is not breaking
  • [NA] Make sure you've added a new test if existing tests do not effectively test the code changed
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

bergmeister
bergmeister approved these changes Feb 19, 2018
View reviewed changes
Copy link
Collaborator

@bergmeister bergmeister left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MWL88 Thanks you for the contribution and welcome to the PSSA repo.
Your change looks good to me, you can expect to get this merged soon. :-)

@MWL88 MWL88 changed the title Fix Markdown so it now renders correctly on GitHub web site Fix Markdown in ScriptRuleDocumentation.md so it renders correctly on GitHub web site Feb 20, 2018
@JamesWTruher JamesWTruher merged commit 8f20c98 into PowerShell:development Feb 20, 2018
@MWL88 MWL88 deleted the fixscriptruledocs branch February 25, 2018 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergmeister bergmeister bergmeister approved these changes

Assignees
No one assigned
Labels
Area - Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ScriptRuleDocumentation.md Markdown does not render correctly on GitHub web site
3 participants
@MWL88 @bergmeister @JamesWTruher