Skip to content

Documentation fixes for AvoidUsingPlainTextForPassword.md #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2016

Conversation

avvi00
Copy link
Contributor

@avvi00 avvi00 commented Jun 3, 2016

Hello,

Some proposed fixes to the documentation:

  • The recommended type in the How to Fix section has a typo.
  • The 'wrong' example was using the correct approach (used SecureString).
  • The 'wrong' example was inconsistent with the 'correct' example in terms of naming and spacing.
  • Examples included extra parameters which (in my opinion) distracted from the point being conveyed.

regards,
Avner


This change is Reviewable

avvi00 added 3 commits June 3, 2016 11:47
The recommended type has a typo.

The 'wrong' and 'correct' examples are inconsistent and include unnecessary extra parameters which (in my opinion) distract from the point being conveyed. Also fixed up spacing.
@msftclas
Copy link

msftclas commented Jun 3, 2016

Hi @avvi00, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

msftclas commented Jun 3, 2016

@avvi00, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@kapilmb
Copy link

kapilmb commented Jun 3, 2016

@avvi00 Thanks for the contribution.

@kapilmb kapilmb merged commit 6eb2735 into PowerShell:development Jun 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants