-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine multiple suppressions applied to the same diagnostic #1699
Conversation
|
||
for (int i = 0; i < suppressed.Length; i += 1) | ||
|
||
// Do any error reporting for misused RuleSuppressionIDs here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JamesWTruher elaborated on error reasoning here
This comment has been minimized.
This comment has been minimized.
Our preferred style is to use the language aliases over the full type names. For example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from a high level. I agree this PR is probably preferential to the original one.
Note that suppression attributes didn't seem to work in PSv4 until I made the change in 498a8c9 |
PR Summary
Fixes #1691.
Instead of emitting a suppressed record for each suppression on a diagnostic, we combine all suppressions that apply to a diagnostic into a single object.
This partially reimplements #1694.
/cc @t-lipingma
PR Checklist
.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
to the beginning of the title and remove the prefix when the PR is ready.