Skip to content

Make UseSingularNouns rule work on PowerShell Core #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 46 commits into from
Apr 28, 2021
Merged

Make UseSingularNouns rule work on PowerShell Core #1627

Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
cdcea4e
Make UseSingularNouns rule work for PowerShell Core versions
bergmeister Jan 23, 2021
8b75e06
fix test
bergmeister Jan 23, 2021
fb51900
fix build
bergmeister Jan 23, 2021
e0132d2
try remove NuGet.Config that led to build failure and use same old ge…
bergmeister Jan 23, 2021
842b866
fix more tests
bergmeister Jan 23, 2021
240f056
fix build
bergmeister Jan 23, 2021
532053c
fix last 2 test failures
bergmeister Jan 23, 2021
930997b
use Pluralize.NET library, which has MIT licence
bergmeister Feb 7, 2021
52ac58a
cleanup diff
bergmeister Feb 7, 2021
f4c19d8
whitespace
bergmeister Feb 7, 2021
9c99b9d
Update SingularNouns rule approach
Apr 23, 2021
7389618
Fix dumb string characters
Apr 23, 2021
9327e6f
Add NuGet.config back
Apr 23, 2021
05ccc2b
Fix namespacing
Apr 23, 2021
ef21d48
Fix pragma casing
Apr 23, 2021
d013b61
Use old index syntax
Apr 23, 2021
a6f08d2
Change singularization for dash cases
rjmholt Apr 23, 2021
1402a5e
Remove dead variables
rjmholt Apr 23, 2021
c40f6c6
Make UseSingularNouns rule work for PowerShell Core versions
bergmeister Jan 23, 2021
d9f2065
fix test
bergmeister Jan 23, 2021
7c3862d
fix build
bergmeister Jan 23, 2021
c6f90fb
try remove NuGet.Config that led to build failure and use same old ge…
bergmeister Jan 23, 2021
ae74050
fix more tests
bergmeister Jan 23, 2021
12e634f
fix build
bergmeister Jan 23, 2021
c474c90
fix last 2 test failures
bergmeister Jan 23, 2021
e8467d7
use Pluralize.NET library, which has MIT licence
bergmeister Feb 7, 2021
ade612b
cleanup diff
bergmeister Feb 7, 2021
b070fda
whitespace
bergmeister Feb 7, 2021
62de267
Update SingularNouns rule approach
Apr 23, 2021
a4eac45
Fix dumb string characters
Apr 23, 2021
6832617
Add NuGet.config back
Apr 23, 2021
adb8081
Fix namespacing
Apr 23, 2021
2372c9e
Fix pragma casing
Apr 23, 2021
c465363
Use old index syntax
Apr 23, 2021
4e1045b
Change singularization for dash cases
rjmholt Apr 23, 2021
d09fcad
Remove dead variables
rjmholt Apr 23, 2021
025d9a4
Add corrections
rjmholt Apr 27, 2021
5e71bf3
Fix correction
rjmholt Apr 27, 2021
5832be4
Add more tests
rjmholt Apr 27, 2021
515a8fe
Put test cases directly in block
rjmholt Apr 27, 2021
2230c9c
Place test cases inline
rjmholt Apr 27, 2021
5d91969
Remove Write-Host
rjmholt Apr 27, 2021
f83f72f
Use an example that isn't broken in .NET Framework
rjmholt Apr 28, 2021
b9b7cb9
Use the right number
rjmholt Apr 28, 2021
ec0ab4b
Fix other tests
rjmholt Apr 28, 2021
8969546
Merge branch 'master' into UseSingularNoun_PSCore
rjmholt Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use old index syntax
  • Loading branch information
Robert Holt authored and Robert Holt committed Apr 23, 2021
commit d013b61add36c47e734f90f2cc89a4e4b6c8df73
2 changes: 1 addition & 1 deletion Rules/UseSingularNouns.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ private string GetLastWordInCmdlet(string cmdletName)
}

// Cmdlet doesn't use CamelCase, so assume it's something like an initialism that shouldn't be singularized
if (!char.IsLower(cmdletName[^1]))
if (!char.IsLower(cmdletName[cmdletName.Length - 1]))
{
return null;
}
Expand Down