Skip to content

move to new signing process for release build and prep for 1.20.0 #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Apr 22, 2021
Merged

move to new signing process for release build and prep for 1.20.0 #1625

Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
150d81e
First cut at new release/signing build yml
JamesWTruher Jan 6, 2021
7943547
remove display name from incorrect location
JamesWTruher Jan 6, 2021
232cb28
change paths for changes in build system
JamesWTruher Jan 6, 2021
21a029a
add debugging info
JamesWTruher Jan 6, 2021
daadefc
Be sure to build all versions
JamesWTruher Jan 7, 2021
1faf27b
change debugging code for 'Copy signed files'
JamesWTruher Jan 7, 2021
d47c013
be sure to be in the correct location for creating the nupkg
JamesWTruher Jan 7, 2021
fd6d5c2
Change nupkg building logic
JamesWTruher Jan 7, 2021
57d4635
make not finding dotnet.exe a non fatal error for loading the module
JamesWTruher Jan 7, 2021
308f923
fix path to suppression file
JamesWTruher Jan 7, 2021
2d1f8f4
debugging statements for compliance
JamesWTruher Jan 7, 2021
5495b95
fix typo for credscan suppressions
JamesWTruher Jan 8, 2021
b535c72
Update to publish build directory
JamesWTruher Jan 8, 2021
caf23fa
Be sure to publish the build directory
JamesWTruher Jan 8, 2021
f9231e5
published signed files need their own name
JamesWTruher Jan 8, 2021
91e0921
add exception for README.md for cred scanner
JamesWTruher Jan 8, 2021
7fafc46
try to get binskim to work with more direct path to assemblies
JamesWTruher Jan 8, 2021
484c051
debugging to find issues with signing files
JamesWTruher Jan 8, 2021
8a6aeb2
fix typo
JamesWTruher Jan 8, 2021
0794d19
more debugging
JamesWTruher Jan 8, 2021
39edbf6
remove debugging
JamesWTruher Jan 8, 2021
a55814b
remove publish of nupkg
JamesWTruher Jan 8, 2021
275cbf2
remove newtonsoft signing stage
JamesWTruher Jan 8, 2021
3dab1f9
try the newton soft signing again
JamesWTruher Jan 8, 2021
29e870d
disable newtonsoft signing
JamesWTruher Jan 8, 2021
5e0a1de
try a 2 step process for signing
JamesWTruher Jan 11, 2021
f0d5e1c
remove most of the debugging code
JamesWTruher Jan 11, 2021
bb976f7
calculate version and publish nupkg
JamesWTruher Jan 12, 2021
7f55032
fix 1 for module version
JamesWTruher Jan 12, 2021
a66cb27
typo for module version
JamesWTruher Jan 12, 2021
2f1cf42
Add a lot of comments to the yaml
JamesWTruher Jan 12, 2021
b6415c3
suppress warnings for using PSRepository cmdlets
JamesWTruher Jan 13, 2021
43935ad
bump version to 1.20.0
JamesWTruher Feb 10, 2021
debd5fc
change to use allowlist in documentation and tests
JamesWTruher Feb 11, 2021
c0714ab
Update .ci/releaseBuild.yml
JamesWTruher Apr 21, 2021
6edaba1
Apply suggestions from code review
rjmholt Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove display name from incorrect location
  • Loading branch information
@JamesWTruher
JamesWTruher committed Feb 10, 2021
commit 7943547ee9a84acd586283d6f2fdc477aaa71aa9
2 changes: 0 additions & 2 deletions .ci/releaseBuild.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ stages:
- checkout: ComplianceRepo

- template: EsrpSign.yml@ComplianceRepo
displayName: "Sign analyzer files"
parameters:
# the folder which contains the binaries to sign
buildOutputPath: $(signSrcPath)
Expand All @@ -80,7 +79,6 @@ stages:
**\Microsoft*.dll

- template: EsrpSign.yml@ComplianceRepo
displayName: "Sign Newtonsoft files with 3rd party cert"
parameters:
# the folder which contains the binaries to sign
buildOutputPath: $(signSrcPath)
Expand Down