Skip to content

Improve performance of UseConsistentIndentation -> 35% speedup for formatter #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2020
Merged

Improve performance of UseConsistentIndentation -> 35% speedup for formatter #1458

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
65b645b
only go back as much as needed
Apr 20, 2020
4ebc4bf
refactor into function
Apr 22, 2020
d5e5229
simplify
Apr 22, 2020
2814147
Apply suggestions from code review
bergmeister Apr 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
simplify
  • Loading branch information
Christoph Bergmeister committed Apr 22, 2020
commit d5e52293036aaba358192dbb2b26d65cf265fb22
6 changes: 2 additions & 4 deletions Rules/UseConsistentIndentation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,6 @@ public override IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string file

private static bool LineHasPipelineBeforeToken(Token[] tokens, int tokenIndex, Token token)
{
bool lineHasPipelineBeforeToken = false;
var searchIndex = tokenIndex;
var searchLine = token.Extent.StartLineNumber;
do
Expand All @@ -265,12 +264,11 @@ private static bool LineHasPipelineBeforeToken(Token[] tokens, int tokenIndex, T
var searchcolumn = tokens[searchIndex].Extent.StartColumnNumber;
if (tokens[searchIndex].Kind == TokenKind.Pipe && searchcolumn < token.Extent.StartColumnNumber)
{
lineHasPipelineBeforeToken = true;
break;
return true;
}
searchIndex--;
} while (searchLine == token.Extent.StartLineNumber && searchIndex >= 0);
return lineHasPipelineBeforeToken;
return false;
}

private static CommandBaseAst LastPipeOnFirstLineWithPipeUsage(PipelineAst pipelineAst)
Expand Down