Skip to content

Multi-stage pipelines (to split build->test) #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Feb 4, 2020
Merged

Multi-stage pipelines (to split build->test) #1404

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
e7a7c54
try using multi-job yaml with different images
bergmeister Feb 2, 2020
2e4c403
fix indentation
bergmeister Feb 2, 2020
e669e48
add vm images to windows build and templatify unix build. Images now …
bergmeister Feb 2, 2020
ca51510
trigger
bergmeister Feb 2, 2020
ac4894c
fix yaml path
bergmeister Feb 2, 2020
d2188be
disable sporadic tests generally and add both Ubuntu images to the tests
bergmeister Feb 2, 2020
ba896ab
job name in quotes and disable redundant appveyor matrix entries
bergmeister Feb 2, 2020
c50c02a
whitespace not allowed for job name
bergmeister Feb 2, 2020
ec0fcb7
dots arent allowed either...
bergmeister Feb 2, 2020
4afd0c6
last fix
bergmeister Feb 2, 2020
a503c15
Merge all entry path yaml files into one yaml.ci file
bergmeister Feb 2, 2020
e31aead
fix windows powershell job
bergmeister Feb 2, 2020
06d6631
tweak step name for ps5 to be consistent
bergmeister Feb 2, 2020
9c4445b
re-trigger
bergmeister Feb 2, 2020
dfe241a
add badge
bergmeister Feb 2, 2020
58df168
multi stage build-test
Feb 3, 2020
b4ef261
bootstrap pester
Feb 3, 2020
2623e58
Cleanup and avoid Pester bootstrap in build stage
Feb 3, 2020
c7bbb5f
download pipeline artifact in test stage
Feb 3, 2020
270bb78
try fix artifact download path
Feb 3, 2020
db7d529
try fix artifact path using '$(Build.SourcesDirectory)/out' and add d…
Feb 3, 2020
7a13f38
fix ps syntax
Feb 3, 2020
ca2c14c
remove debugging step
Feb 3, 2020
e4717dd
Fix suggestion text to have platform specific newlines and enable tes…
Feb 3, 2020
4459f9e
add more windows images
Feb 3, 2020
c34fb1a
try use strategy
Feb 3, 2020
164bca3
try
Feb 3, 2020
329f712
fix job name
Feb 3, 2020
f5edd4e
rename and try to not use a job name
Feb 3, 2020
5c8bb36
remove pwsh variable, which is now redundant as it is now in test.yaml
Feb 3, 2020
06309b8
remove old comment
Feb 3, 2020
6ff0c07
try fix tests on wmf4
Feb 3, 2020
bb95ab4
try use -be instead of -match operator
Feb 3, 2020
8eaf6fd
fix wmf4 test failure due to CRLF not being correctly used in this ve…
Feb 3, 2020
20e5b1b
Merge branch 'master' of https://github.com/powershell/psscriptanalyz…
Feb 3, 2020
9f81fab
make pscompatiblitycollector build against all frameworks again
Feb 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix suggestion text to have platform specific newlines and enable tes… 
…t on Linux
  • Loading branch information
Christoph Bergmeister committed Feb 3, 2020
commit e4717dd011ebe97c8b48e63a96e9507410b5cdd1
7 changes: 3 additions & 4 deletions Rules/MissingModuleManifestField.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,9 @@ private List<CorrectionExtent> GetCorrectionExtent(HashtableAst ast)
Strings.MissingModuleManifestFieldCorrectionDescription,
fieldName,
fieldValue);
var correctionTextTemplate = @"
# Version number of this module.
{0} = '{1}'
";
var correctionTextTemplate = string.Concat(Environment.NewLine,
"# Version number of this module.", Environment.NewLine,
"{0} = '{1}'", Environment.NewLine);
var correctionText = string.Format(
correctionTextTemplate,
fieldName,
Expand Down
2 changes: 1 addition & 1 deletion Tests/Rules/AvoidUnloadableModuleOrMissingRequiredFieldInManifest.tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Describe "MissingRequiredFieldModuleManifest" {
}

# On Linux, mismatch in line endings cause this to fail
It "has the right suggested correction" -Skip:($IsLinux) {
It "has the right suggested correction" {
$expectedText = @'
# Version number of this module.
ModuleVersion = '1.0.0.0'
Expand Down