Skip to content

Fix ps3 syntax check #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 4, 2020
Merged

Fix ps3 syntax check #1395

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5a42e28
Remove erroneous ps3 dynamic member warning
rjmholt Jan 16, 2020
0a74ee6
Upgrade compatible syntax rule to emit errors
rjmholt Jan 16, 2020
8bde76d
Fix tests
rjmholt Jan 16, 2020
4e1bfeb
Fix last test
rjmholt Jan 16, 2020
fc0ccbe
Fix tests to account for severity change
Feb 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests
  • Loading branch information
@rjmholt
rjmholt committed Jan 16, 2020
commit 8bde76d2e528b0d94b0f57b68b6795f4e288f9af
33 changes: 1 addition & 32 deletions Tests/Rules/UseCompatibleSyntax.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,42 +3,11 @@

$script:RuleName = 'PSUseCompatibleSyntax'

$script:ScriptDefinition = @'
class MyClass
{
[string]$Hi = "Hello"

[string]GetString()
{
return $this.Hi
}
}

enum MyEnum
{
One,
Two
}

$x = [MyClass]::new()

$member = 'Hi'
Write-Host $x.$member

Write-Output 'Banana'

$method = 'GetString'
$x.$method()

$enumVal = "One"
[MyEnum]::$enumVal
'@

Describe "PSUseCompatibleSyntax" {
BeforeAll {
$testCases = @(
@{ Script = '$x = [MyClass]::new()'; Versions = @(3,4) }
@{ Script = '$member = "Hi"; $x.$member'; Versions = @(3) }
@{ Script = '$member = "Hi"; $x.$member'; Versions = @() }
@{ Script = 'Write-Host "Banana"'; Versions = @() }
@{ Script = '[System.VeryInnocuousType]::RunApiMethod($obj)'; Versions = @() }
@{ Script = '$y.$methodWithAVeryLongName()'; Versions = @(3) }
Expand Down