Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Where-Object instead of alias in buildmodule.tests.ps1 #1360

Merged
merged 2 commits into from
Jan 3, 2020

Conversation

kvprasoon
Copy link
Contributor

PR Summary

Use Where-Object instead of ? in BuildModule.tests.ps1

PR Checklist

@kvprasoon
Copy link
Contributor Author

@bergmeister any idea on CI failures ?

@bergmeister
Copy link
Collaborator

bergmeister commented Oct 27, 2019

The first failure is a relatively new, but known sporadic failure, for which PR #1358 has been opened.
The other 4 failures started to happen only this week without a code change in master and are probably due to a breaking change in an AppVeyor image update.
Concluding, don't worry about them, they are unrelated and not blocking your PR from being merged but ideally, we want to have them fixed in master first before merging more PRs.

@bergmeister bergmeister merged commit 18d0f03 into PowerShell:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants