Skip to content

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Feb 4, 2025

PR Summary

Fix #3939

Handle buffer changes made by a handler of the OnIdle event.
We don't update the initial cursor top when buffer was changed by an event handler.

It requires interaction with PowerShell to test out this change, and thus I cannot add an automation test.

buffer

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw daxian-dbw merged commit 1ea00df into PowerShell:master Feb 4, 2025
2 checks passed
@daxian-dbw daxian-dbw deleted the insert branch February 4, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Newline Handling of [Microsoft.PowerShell.PSConsoleReadLine]::Insert broken in Windows

1 participant