Skip to content

Address feedback to the scrollable list view from Andy #3600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2023
Merged

Address feedback to the scrollable list view from Andy #3600

merged 1 commit into from
Feb 28, 2023

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Feb 28, 2023 •
edited by ghost
Loading

PR Summary

Address feedback to the scrollable list view from Andy.
The feedback comments are from this review: #3583 (review)

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw daxian-dbw self-assigned this Feb 28, 2023
@daxian-dbw daxian-dbw mentioned this pull request Feb 28, 2023
Merged
7 tasks
@daxian-dbw daxian-dbw merged commit 259d82e into PowerShell:master Feb 28, 2023
@daxian-dbw daxian-dbw deleted the fb branch February 28, 2023 00:12
andyleejordan
andyleejordan reviewed Feb 28, 2023
View reviewed changes
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆 there wasn't much, it didn't matter! But thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andyleejordan andyleejordan andyleejordan left review comments

Assignees

@daxian-dbw daxian-dbw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daxian-dbw @andyleejordan