Fix the menu completion to better handle the backspace key #3574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
approved these changes
Feb 27, 2023
Comment on lines
+998
to
+1004
| // else { | ||
| // We should not pop the stack yet. The updated user completion text contains characters | ||
| // that are not included in the selected item of the menu at the top of stack. This may | ||
| // happen when the user pressed a 'Tab' before this 'Backspace', which updated the user | ||
| // completion text to include the unambiguous common prefix of the available completion | ||
| // candidates. In this case, we should stay in the current menu. | ||
| // } |
Member
There was a problem hiding this comment.
Ahh thank you super helpful comment 😄
Member
Author
|
@andschwa Thanks for the review! |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #3559
Fix the menu completion to better handle the backspace key.
Keep this a draft PR until after adding tests.
PR Checklist
Microsoft Reviewers: Open in CodeFlow