Skip to content

Updating readme for clearer build instructions #3550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 25, 2023
Merged

Updating readme for clearer build instructions #3550

merged 4 commits into from
Jan 25, 2023

Conversation

@StevenBucher98
Copy link
Collaborator

@StevenBucher98 StevenBucher98 commented Jan 24, 2023 •
edited by ghost
Loading

PR Summary

Adding more detail on how to isolate PSReadLine module build. Helps with #3451

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

daxian-dbw
daxian-dbw requested changes Jan 24, 2023
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left 2 minor comments.

@StevenBucher98 @daxian-dbw
Update README.md
61248a7 
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
@ghost ghost removed the Needs-Author Feedback label Jan 25, 2023
@StevenBucher98 @daxian-dbw
Update README.md
bb03c1e 
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
daxian-dbw
daxian-dbw approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw merged commit 9957183 into PowerShell:master Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StevenBucher98 @daxian-dbw