Skip to content

Fix incorrect cursor position in menu completion #3373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2022
Merged

Fix incorrect cursor position in menu completion #3373

merged 1 commit into from
Jul 8, 2022

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Jul 6, 2022 •
edited by ghost
Loading

PR Summary

Fix #3369
Fix incorrect cursor position in menu completion.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw daxian-dbw requested a review from andyleejordan July 6, 2022 21:01
@daxian-dbw daxian-dbw merged commit e9d4242 into PowerShell:master Jul 8, 2022
@daxian-dbw daxian-dbw deleted the menu branch July 8, 2022 22:32
@daxian-dbw
Copy link
Member Author

daxian-dbw commented Jul 8, 2022

Thanks @andschwa for the review!

@ghost
Copy link

ghost commented Mar 8, 2023

🎉 v2.3.0-beta0 has been released which incorporates this pull request. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andyleejordan andyleejordan andyleejordan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MenuComplete on a cmdlet with a long signature moves the cursor to an incorrect position

2 participants

@daxian-dbw @andyleejordan