Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Add Archive resource #41

Merged
merged 1 commit into from
Feb 23, 2017
Merged

Add Archive resource #41

merged 1 commit into from
Feb 23, 2017

Conversation

kwirkykat
Copy link
Member

@kwirkykat kwirkykat commented Feb 23, 2017

Adding the cleaned Archive resource.


This change is Reviewable

@kwirkykat kwirkykat added the needs review The pull request needs a code review. label Feb 23, 2017
@kwirkykat kwirkykat requested a review from mbreakey3 February 23, 2017 00:24
@msftclas
Copy link

Hi @kwirkykat, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor. If you're full-time or an intern, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@codecov-io
Copy link

codecov-io commented Feb 23, 2017

Codecov Report

Merging #41 into dev will increase coverage by 1%.
The diff coverage is 89%.

@@         Coverage Diff          @@
##            dev    #41    +/-   ##
====================================
+ Coverage    80%    81%    +1%     
====================================
  Files        15     16     +1     
  Lines      2149   2448   +299     
  Branches      4      4            
====================================
+ Hits       1736   2005   +269     
- Misses      409    439    +30     
  Partials      4      4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd6a318...1f0238b. Read the comment docs.

@mbreakey3
Copy link
Member

:lgtm:


Reviewed 19 of 19 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Tests/Integration/MSFT_Archive.EndToEnd.Tests.ps1, line 3 at r1 (raw file):

$errorActionPreference = 'Stop'
Set-StrictMode -Version 'Latest'

Should we still add in the 'if not on 5.1' check?


Comments from Reviewable

@mbreakey3
Copy link
Member

Just had the comment about the integration tests still requiring the 5.1 check or not


Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@kwirkykat
Copy link
Member Author

Review status: 17 of 19 files reviewed at latest revision, 1 unresolved discussion.


Tests/Integration/MSFT_Archive.EndToEnd.Tests.ps1, line 3 at r1 (raw file):

Previously, mbreakey3 (Mariah) wrote…

Should we still add in the 'if not on 5.1' check?

Added it


Comments from Reviewable

@mbreakey3
Copy link
Member

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@kwirkykat kwirkykat merged commit 2bddfa7 into PowerShell:dev Feb 23, 2017
@kwirkykat kwirkykat deleted the AddArchive branch February 23, 2017 01:04
@kwirkykat kwirkykat removed the needs review The pull request needs a code review. label Feb 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants