Migrate Recent Fixes from xPSDesiredStateConfiguration Archive Resource - Fixes #126

[PlagueHO]

This PR includes the following fixes and improvements:

• Ported fixes from xPSDesiredStateConfiguration:
  • xArchive
    • Fix end-to-end tests.
    • Update integration tests to meet Pester 4.0.0 standards.
    • Update end-to-end tests to meet Pester 4.0.0 standards.
    • Update unit and integration tests to meet Pester 4.0.0 standards.
    • Wrapped all verbose message parameters with quotes to make identifying
      actual paths possible.
    • Refactored date/time checksum code to improve testability and ensure
      tests can run on machines with localized datetime formats that are not
      US.
    • Fix 'Get-ArchiveEntryLastWriteTime' to return [datetime].
    • Improved verbose logging to make debugging path issues easier.
• Added .gitattributes file to ensure CRLF settings are configured correctly
  for the repository.
• Updated '.vscode\settings.json' to refer to AnalyzerSettings.psd1 so that
  custom syntax problems are highlighted in Visual Studio Code.
• Fixed style guideline violations in CommonResourceHelper.psm1.
• Updated 'appveyor.yml' to meet more recent standards.
• Removed OS image version from 'appveyor.yml' to use default image
  (Issue #127.
• Removed code to install WMF5.1 from 'appveyor.yml' because it is already
  installed in AppVeyor images (Issue #128.
• Removed .vscode from .gitignore so that Visual Studio code environment
  settings can be committed.

• Fixes WMF 5.1 Is Being Installed in AppVeyor For Some Reason #128
• Fixes Old AppVeyor Image is Being Used #127

@johlju - sorry about the size of this one, but Archive is quite out of date with current HQRM standards so I had to clean it up. Would you mind reviewing at some point? Although @kwirkykat or @mgreenegit may need to still review and merge.

---

This change is 

[codecov-io]

Codecov Report

Merging #130 into dev will increase coverage by <1%.
The diff coverage is 85%.

@@         Coverage Diff          @@
##            dev   #130    +/-   ##
====================================
+ Coverage    83%    83%   +<1%     
====================================
  Files        19     19            
  Lines      2755   2760     +5     
  Branches      4      4            
====================================
+ Hits       2300   2305     +5     
  Misses      451    451            
  Partials      4      4

[johlju]

@PlagueHO You should add Fixes #xxx to the PR description as it seems to fix more than one issue?

[johlju]

Reviewed 12 of 12 files at r1, 3 of 3 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @PlagueHO)

---

Tests/Unit/MSFT_Archive.Tests.ps1, line 2194 at r2 (raw file):

creation time

last write time?

[johlju]

@PlagueHO Yes, since DSC team supports this module I think @kwirkykat should approve and merge once we see it is ready (passing our review).

[johlju]

@PlagueHO Maybe (in the future) we should split the functional changes and the code clean up/repo maintenance changes so it is easier (faster) for @kwirkykat to review the actual resource(s) functional changes? 🤔

[johlju]

Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved

[PlagueHO]

Thanks @johlju - added the -Fixes for the other issues. We need to include the .github templates into this repo so that it would have prompted me 😁

[johlju]

Thet are waiting in PR #113. Probably needs a rebase by now. If you review that I can rebase it tomorrow.