Skip to content
This repository was archived by the owner on Jun 14, 2024. It is now read-only.

Remove hardcoded .so from MI_PlatformSpecific.cs #34

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Remove hardcoded .so from MI_PlatformSpecific.cs #34

merged 1 commit into from
Aug 5, 2019

Conversation

adityapatwardhan
Copy link
Member

Fixes #33

Remove hardcoded .so from the MI_PlatformSpecific.cs to fix loading on MacOS.

TravisEz13
TravisEz13 approved these changes Jan 23, 2019
View reviewed changes
Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please validate before merging

joshdean1
joshdean1 suggested changes Mar 17, 2019
View reviewed changes
Copy link

@joshdean1 joshdean1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since removing the .so, the below error now appears:

System.DllNotFoundException: Unable to load shared library 'libmi.so' or one of its dependencies.

@adityapatwardhan
Copy link
Member Author

adityapatwardhan commented Aug 5, 2019 •
edited
Loading

Tested it on a private build. Basic tests worked fine.

@adityapatwardhan adityapatwardhan merged commit cf32fc6 into PowerShell:master Aug 5, 2019
@adityapatwardhan adityapatwardhan deleted the FixMacOS branch August 5, 2019 19:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joshdean1 joshdean1 joshdean1 requested changes

@TravisEz13 TravisEz13 TravisEz13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doesn't work for macOS
3 participants
@adityapatwardhan @joshdean1 @TravisEz13