Parameters are shown using variables-color

[fflaten]

Environment

• Editor and Version (VS Code, Atom, Sublime): VS Code
• Your primary theme: One Dark Pro

Issue Description

While semantic highlighting is enabled (theme default), parameters are shown using the same color as the variables, making it hard to split parameter from value. Literals are shown using their separate color as expected.

Also tested with Powershell ISE theme.

Screenshots

Semantic highlighting enabled:

Expected Behavior

Variables and parameters should have different colors like before.

Semantic highlighting disabled in settings:

Code Samples

Get-ChildItem -Path $path -Filter $filter -Include 'literal value'

[bitdeft]

I came here to echo this issue. This seems to be related to the new semantic highlighting feature.
Please update it so that the parameters use white or grey as they before.

Primary Theme: Dark+

[msftrncs]

white or grey is not the correct color! That is a lack of color, and was caused by EditorSyntax choosing no scoping for those tokens.

However, that is up to your theme to choose the color, not for either EditorSyntax or the semantic tokenizer. They only specify what an object is.

Here's how mine looks: (without semantic highlighting, and a custom PS grammar)

[msftrncs]

Also, semantic token highlighting issues need to be taken over to https://github.com/PowerShell/vscode-powershell. The semantic tokenizing is handled in the PowerShell extension, not in the basic language syntaxing module here. The PowerShell ISE Theme also comes from there as well.

[fflaten]

@msftrncs I'm not sure how the picture of your theme without semantic helps. Maybe most/all themes forgot to color the parameters before, but the end result is that it worked. The issue is only when semantic is enabled. Are we sure the themes can separate the token types?

I was redirected here for "editor syntax colorization issues" in vscode-powershell's new issue template-menu. If that's wrong, you might want to make them rephrase or change that, because atm you both point at each other.

[fflaten]

Related PowerShell/vscode-powershell#3221

[andyleejordan]

@fflaten I've updated our FAQ to clarify the interaction between the extension's highlighting and the highlighting grammar (this repo): https://github.com/PowerShell/vscode-powershell/blob/master/docs/troubleshooting.md#problems-with-syntax-highlighting

Funnily enough, I've also updated the issue form on the extension...but GitHub still hasn't added us to the beta for new issue forms so it's still a draft PR: PowerShell/vscode-powershell#3332

[fflaten]

Thanks @andschwa. I also noticed that the editor syntax-redirect in the issue template is removed in vscode-powershell 👍
I've lately switched to Github Dark theme which works far better with semantic enabled. It has a lot more tokenColors defined which I guess help separate parameters and variables properly.

Haven't looked into which tokenColor that fixed it, but I guess this might now be more of a theme-issue with "PowerShell ISE".

Btw. didn't know about the issue forms private beta). They look awesome!