Convert pending reboot to object #859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SteveL-MSFT I thought of simply making this an object and removing the read-only property. Perhaps I'm missing something in the schema, but this allows the property to be still optional. |
Gijsreyn
force-pushed
the
fix-pending-reboot
branch
from
43832e0 to
0e1ddd2
Compare
|
Thanks for the review Mikey. I also added your remark from #857 on exit codes. |
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit:
Suggested change
| } | |
| } |
michaeltlombardi
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR addresses issue #858. This was found while writing the reference documentation in #857.
PR Context