Skip to content

Convert pending reboot to object #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Gijsreyn
Copy link
Contributor

@Gijsreyn Gijsreyn commented Jun 3, 2025

PR Summary

This PR addresses issue #858. This was found while writing the reference documentation in #857.

PR Context

@Gijsreyn
Copy link
Contributor Author

Gijsreyn commented Jun 3, 2025

@SteveL-MSFT I thought of simply making this an object and removing the read-only property. Perhaps I'm missing something in the schema, but this allows the property to be still optional.

@Gijsreyn Gijsreyn force-pushed the fix-pending-reboot branch from 43832e0 to 0e1ddd2 Compare June 4, 2025 01:40
@Gijsreyn
Copy link
Contributor Author

Gijsreyn commented Jun 5, 2025

Thanks for the review Mikey. I also added your remark from #857 on exit codes.

@Gijsreyn Gijsreyn requested a review from michaeltlombardi June 5, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants