Change reference() to use the raw output of a resource
#634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (1)
- dsc/tests/dsc_reference.tests.ps1: Language not supported
Comments suppressed due to low confidence (1)
dsc_lib/src/functions/reference.rs:33
- The error message should be updated to specify that the key was not found in 'references' instead of 'outputs'.
Err(DscError::Parser(t!("functions.reference.keyNotFound", key = key).to_string()))
tgauth
reviewed
Feb 5, 2025
| $out = dsc config get -f $PSScriptRoot/../examples/reference.dsc.yaml | ConvertFrom-Json | ||
| It 'Reference works for <operation>' -TestCases @( | ||
| @{ operation = 'get' }, | ||
| @{ operation = 'test' } |
There was a problem hiding this comment.
are there any tests for reference with set and export?
There was a problem hiding this comment.
Not at this time, will add later
tgauth
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
As discussed,
reference()now refers to the raw output of a prior resource invocation and not the decorated one that comes from DSC engine. This is because the decoration is different forget,set,test, andexportsuch that use of this function means you can't use the same config for bothgetandtest, for example.Had to update version of tree-sitter to get past the failures in CI but not locally (also updated some other crates)
Also renamed an internal member to
referencesinstead ofoutputsso that the comment is no longer needed.We'll defer the ability to access the decorated output as it's additive and not breaking until we have a real scenario to need it.
PR Context
Fix #389