Skip to content

Clean-up main model: index-less single-scenario calculation #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: virtual-adapter-prototipe
Choose a base branch
from

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Aug 6, 2025

This PR:

  • somewhat cleans up the code in main model
  • fixes a minor bug in the internal code in the dataset + adds a test for it. No user was affected because the code path was never hit.

This is a follow-up to #1036 with the intention to make the main model less aware of all the implementation details behind doing batch calculations.

mgovers added 3 commits August 6, 2025 07:36
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers requested a review from figueroa1395 August 6, 2025 14:18
@mgovers mgovers self-assigned this Aug 6, 2025
@mgovers mgovers added the improvement Improvement on internal implementation label Aug 6, 2025
@mgovers mgovers changed the base branch from main to virtual-adapter-prototipe August 6, 2025 14:18
mgovers and others added 8 commits August 7, 2025 07:14
…x-less-single-calculation

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Copy link

sonarqubecloud bot commented Aug 7, 2025

@mgovers mgovers added the do-not-merge This should not be merged label Aug 7, 2025
@mgovers
Copy link
Member Author

mgovers commented Aug 7, 2025

do-not-merge label added because it depends on #1036

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge This should not be merged improvement Improvement on internal implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants