auth: http api fixes - #17870
Conversation
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
…Sets. This makes the generated example for the GET .../zones endpoint closer to reality. Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
As far as I can tell, it has never been implemented. Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
It would behave as POST on .../cryptokeys and wasn't documented anyway. Fixes: PowerDNS#17807 Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
|
Fixes: #17834 |
Coverage Report for CI Build 31075284551Coverage increased (+5.2%) to 71.199%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions47 previously-covered lines in 12 files lost coverage.
Coverage Stats💛 - Coveralls |
| last_check: | ||
| type: integer | ||
|
|
||
| ZoneWithoutRRSets: |
There was a problem hiding this comment.
this feels like terrible duplication, and the "/servers/{server_id}/zones/{zone_id}" endpoint supports rrsets=false - for which I have no idea if a strict openapi client accepts that (we should find out)
I also notice that in the Zone schema, we already clarify description: "RRSets in this zone (for zones/{zone_id} endpoint only; omitted during GET on the .../zones list endpoint)"
There was a problem hiding this comment.
I don't know if it is possible to declare Zone as being ZoneWithoutRRSets plus the count and rrset fields. This sure would help.
I also notice that in the
Zoneschema, we already clarifydescription: "RRSets in this zone (for zones/{zone_id} endpoint only; omitted during GET on the .../zones list endpoint)"
Unfortunately, the generated example in the documentation do not copy anything from the description. Which is why the ..../zones example had rrsets in the sample output in the first place.
| default: | ||
| $ref: "#/components/responses/Error" | ||
|
|
||
| "/servers/{server_id}/config/{config_setting_name}": |
There was a problem hiding this comment.
responding to "As far as I can tell, it has never been implemented." in the commit message: any and all evidence I can find in git history is that besides this openapi doc, the /servers/{server_id} endpoint has also claimed its existence. I agree with removing it from this spec.
Short description
This PR addresses recent reports of documentation inaccuracies.
Checklist
I have: