Skip to content

Conversation

@miodvallat
Copy link
Contributor

Short description

One of the tests added in #16589 depends upon the order records will be returned by the backend. Fix this to let it work regardless of that order.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
@miodvallat miodvallat added the auth label Dec 5, 2025
miodvallat added a commit to miodvallat/pdns that referenced this pull request Dec 5, 2025
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
miodvallat added a commit to miodvallat/pdns that referenced this pull request Dec 5, 2025
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19967963078

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 58 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.02%) to 73.31%

Files with Coverage Reduction New Missed Lines %
pdns/iputils.hh 1 76.22%
pdns/recursordist/aggressive_nsec.cc 2 66.69%
modules/gpgsqlbackend/spgsql.cc 3 67.94%
pdns/dnsdistdist/dnsdist-carbon.cc 3 62.01%
pdns/recursordist/recpacketcache.hh 3 89.55%
pdns/recursordist/test-syncres_cc2.cc 3 89.18%
pdns/remote_logger.cc 3 58.62%
pdns/tsigverifier.cc 3 77.22%
pdns/recursordist/syncres.cc 4 81.1%
pdns/misc.cc 6 61.73%
Totals Coverage Status
Change from base Build 19964475555: -0.02%
Covered Lines: 128707
Relevant Lines: 164801

💛 - Coveralls

@Habbie Habbie merged commit b393535 into PowerDNS:master Dec 8, 2025
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants